Complete NextSteps roadmap: planning engine UI, calendar cluster, flexible wishes
Works through every numbered item in NextSteps260913.md section 3, plus the three known verification issues in section 4.1. Surface what the backend already computed: - 3.1 render surplus_advice in PlanResults, mirroring the shortfall remedies - 3.2 surface VacationBalance.is_assumed so assumed statutory years are visible - 3.3 age-4 expiry given the proposed plan, via a new Age4Projection reusing the existing _age4_projections arithmetic (Dashboard stat verified, not rebuilt) Calendar cluster (one pass over the holiday data): - new GET /api/calendar/days exposing roda dagar, klamdagar and day overrides, paginated four years at a time - 3.4 shade roda dagar/klamdagar, with R/K badges so colour is not the only signal - 3.6 click-to-override behind an explicit mode toggle, leaving drag multi-select intact - 3.7 click month/year to advance - 3.8 per-year red-days list in Settings, statutory days plus overrides i18n: - 3.5 five backend-generated Swedish surfaces converted to message_key + data, following the tips_service pattern; old string fields replaced, not kept Flexible wishes (3.9): - PLANNING_ENGINE_SPEC section 10: window_mode, candidate search, cost function, deterministic tie-break, two-pass ordering, test matrix rows 15-24 - backend: entity, migration 006, _FULL_SCHEMA sync, repository, allocator - frontend: season-preset toggle in WishEditor, unplaced outcome rendering Fixes (4.1): - pin typecheck to the local tsc rather than npx resolving a newer TypeScript - ignore generated coverage/ and dist/ in the ESLint flat config - fix the flaky usePlanApply test properly, with waitFor rather than a retry Tests: backend 361 -> 404, frontend 540 -> 704. Coverage 89.47% -> 96.52% lines. Not yet verified in a browser. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RXMhc9nT6sNz1SL4j8dznL
This commit is contained in:
@@ -0,0 +1,243 @@
|
||||
import { describe, it, expect, beforeEach, vi } from 'vitest'
|
||||
import { render, screen, fireEvent, waitFor } from '@testing-library/react'
|
||||
import { DayOverridesInput } from './DayOverridesInput'
|
||||
|
||||
describe('DayOverridesInput', () => {
|
||||
const mockOverrides = [
|
||||
{
|
||||
id: 'do-1',
|
||||
workspaceId: 'ws-1',
|
||||
date: '2026-12-24',
|
||||
isWorkingDay: true,
|
||||
note: 'Jobbade på juldagen',
|
||||
createdAt: '2026-01-01T00:00:00',
|
||||
updatedAt: '2026-01-01T00:00:00',
|
||||
},
|
||||
{
|
||||
id: 'do-2',
|
||||
workspaceId: 'ws-1',
|
||||
date: '2026-06-20',
|
||||
isWorkingDay: false,
|
||||
note: null,
|
||||
createdAt: '2026-01-01T00:00:00',
|
||||
updatedAt: '2026-01-01T00:00:00',
|
||||
},
|
||||
]
|
||||
|
||||
let mockOnAdd: ReturnType<typeof vi.fn>
|
||||
let mockOnRemove: ReturnType<typeof vi.fn>
|
||||
|
||||
beforeEach(() => {
|
||||
mockOnAdd = vi.fn().mockResolvedValue(undefined)
|
||||
mockOnRemove = vi.fn().mockResolvedValue(undefined)
|
||||
})
|
||||
|
||||
describe('rendering', () => {
|
||||
it('renders list of existing overrides', () => {
|
||||
render(
|
||||
<DayOverridesInput
|
||||
overrides={mockOverrides}
|
||||
onAdd={mockOnAdd}
|
||||
onRemove={mockOnRemove}
|
||||
workspaceId="ws-1"
|
||||
/>
|
||||
)
|
||||
|
||||
expect(screen.getByText('24 december 2026')).toBeInTheDocument()
|
||||
expect(screen.getByText('20 juni 2026')).toBeInTheDocument()
|
||||
})
|
||||
|
||||
it('renders working day override with correct status', () => {
|
||||
render(
|
||||
<DayOverridesInput
|
||||
overrides={mockOverrides}
|
||||
onAdd={mockOnAdd}
|
||||
onRemove={mockOnRemove}
|
||||
workspaceId="ws-1"
|
||||
/>
|
||||
)
|
||||
|
||||
expect(screen.getByTestId('override-item-do-1').textContent).toContain('Jag jobbar den här dagen')
|
||||
})
|
||||
|
||||
it('renders off day override with correct status', () => {
|
||||
render(
|
||||
<DayOverridesInput
|
||||
overrides={mockOverrides}
|
||||
onAdd={mockOnAdd}
|
||||
onRemove={mockOnRemove}
|
||||
workspaceId="ws-1"
|
||||
/>
|
||||
)
|
||||
|
||||
expect(screen.getByTestId('override-item-do-2').textContent).toContain('Jag är ledig den här dagen')
|
||||
})
|
||||
|
||||
it('renders note when present', () => {
|
||||
render(
|
||||
<DayOverridesInput
|
||||
overrides={mockOverrides}
|
||||
onAdd={mockOnAdd}
|
||||
onRemove={mockOnRemove}
|
||||
workspaceId="ws-1"
|
||||
/>
|
||||
)
|
||||
|
||||
expect(screen.getByText('Anteckning: Jobbade på juldagen')).toBeInTheDocument()
|
||||
})
|
||||
|
||||
it('renders empty state when no overrides', () => {
|
||||
render(
|
||||
<DayOverridesInput
|
||||
overrides={[]}
|
||||
onAdd={mockOnAdd}
|
||||
onRemove={mockOnRemove}
|
||||
workspaceId="ws-1"
|
||||
/>
|
||||
)
|
||||
|
||||
expect(screen.getByText('Du har inga undantag i kalendern ännu.')).toBeInTheDocument()
|
||||
})
|
||||
|
||||
it('renders add form with all fields', () => {
|
||||
render(
|
||||
<DayOverridesInput
|
||||
overrides={[]}
|
||||
onAdd={mockOnAdd}
|
||||
onRemove={mockOnRemove}
|
||||
workspaceId="ws-1"
|
||||
/>
|
||||
)
|
||||
|
||||
expect(screen.getByTestId('override-date-input')).toBeInTheDocument()
|
||||
expect(screen.getByTestId('override-working-radio')).toBeInTheDocument()
|
||||
expect(screen.getByTestId('override-off-radio')).toBeInTheDocument()
|
||||
expect(screen.getByTestId('override-note-input')).toBeInTheDocument()
|
||||
expect(screen.getByTestId('add-override-button')).toBeInTheDocument()
|
||||
})
|
||||
})
|
||||
|
||||
describe('adding override', () => {
|
||||
it('calls onAdd with correct payload when working day is selected', async () => {
|
||||
render(
|
||||
<DayOverridesInput
|
||||
overrides={[]}
|
||||
onAdd={mockOnAdd}
|
||||
onRemove={mockOnRemove}
|
||||
workspaceId="ws-1"
|
||||
/>
|
||||
)
|
||||
|
||||
fireEvent.change(screen.getByTestId('override-date-input'), { target: { value: '2026-12-24' } })
|
||||
fireEvent.click(screen.getByTestId('override-working-radio'))
|
||||
fireEvent.change(screen.getByTestId('override-note-input'), { target: { value: 'Jobbar denna dag' } })
|
||||
fireEvent.click(screen.getByTestId('add-override-button'))
|
||||
|
||||
await waitFor(() => {
|
||||
expect(mockOnAdd).toHaveBeenCalledWith({
|
||||
workspaceId: 'ws-1',
|
||||
date: '2026-12-24',
|
||||
isWorkingDay: true,
|
||||
note: 'Jobbar denna dag',
|
||||
})
|
||||
})
|
||||
})
|
||||
|
||||
it('calls onAdd with correct payload when off day is selected', async () => {
|
||||
render(
|
||||
<DayOverridesInput
|
||||
overrides={[]}
|
||||
onAdd={mockOnAdd}
|
||||
onRemove={mockOnRemove}
|
||||
workspaceId="ws-1"
|
||||
/>
|
||||
)
|
||||
|
||||
fireEvent.change(screen.getByTestId('override-date-input'), { target: { value: '2026-06-20' } })
|
||||
fireEvent.click(screen.getByTestId('override-off-radio'))
|
||||
fireEvent.click(screen.getByTestId('add-override-button'))
|
||||
|
||||
await waitFor(() => {
|
||||
expect(mockOnAdd).toHaveBeenCalledWith({
|
||||
workspaceId: 'ws-1',
|
||||
date: '2026-06-20',
|
||||
isWorkingDay: false,
|
||||
note: null,
|
||||
})
|
||||
})
|
||||
})
|
||||
|
||||
it('clears form after successful add', async () => {
|
||||
render(
|
||||
<DayOverridesInput
|
||||
overrides={[]}
|
||||
onAdd={mockOnAdd}
|
||||
onRemove={mockOnRemove}
|
||||
workspaceId="ws-1"
|
||||
/>
|
||||
)
|
||||
|
||||
const dateInput = screen.getByTestId('override-date-input') as HTMLInputElement
|
||||
const noteInput = screen.getByTestId('override-note-input') as HTMLInputElement
|
||||
|
||||
fireEvent.change(dateInput, { target: { value: '2026-12-24' } })
|
||||
fireEvent.change(noteInput, { target: { value: 'Test note' } })
|
||||
fireEvent.click(screen.getByTestId('add-override-button'))
|
||||
|
||||
await waitFor(() => {
|
||||
expect(dateInput.value).toBe('')
|
||||
expect(noteInput.value).toBe('')
|
||||
})
|
||||
})
|
||||
|
||||
it('disables submit button when date is empty', () => {
|
||||
render(
|
||||
<DayOverridesInput
|
||||
overrides={[]}
|
||||
onAdd={mockOnAdd}
|
||||
onRemove={mockOnRemove}
|
||||
workspaceId="ws-1"
|
||||
/>
|
||||
)
|
||||
|
||||
const submitButton = screen.getByTestId('add-override-button') as HTMLButtonElement
|
||||
expect(submitButton.disabled).toBe(true)
|
||||
})
|
||||
})
|
||||
|
||||
describe('removing override', () => {
|
||||
it('calls onRemove with correct id', async () => {
|
||||
render(
|
||||
<DayOverridesInput
|
||||
overrides={mockOverrides}
|
||||
onAdd={mockOnAdd}
|
||||
onRemove={mockOnRemove}
|
||||
workspaceId="ws-1"
|
||||
/>
|
||||
)
|
||||
|
||||
fireEvent.click(screen.getByTestId('remove-override-do-1'))
|
||||
|
||||
await waitFor(() => {
|
||||
expect(mockOnRemove).toHaveBeenCalledWith('do-1')
|
||||
})
|
||||
})
|
||||
})
|
||||
|
||||
describe('loading state', () => {
|
||||
it('disables form during loading', () => {
|
||||
render(
|
||||
<DayOverridesInput
|
||||
overrides={[]}
|
||||
isLoading={true}
|
||||
onAdd={mockOnAdd}
|
||||
onRemove={mockOnRemove}
|
||||
workspaceId="ws-1"
|
||||
/>
|
||||
)
|
||||
|
||||
expect((screen.getByTestId('override-date-input') as HTMLInputElement).disabled).toBe(true)
|
||||
expect((screen.getByTestId('add-override-button') as HTMLButtonElement).disabled).toBe(true)
|
||||
})
|
||||
})
|
||||
})
|
||||
Reference in New Issue
Block a user