Complete NextSteps roadmap: planning engine UI, calendar cluster, flexible wishes

Works through every numbered item in NextSteps260913.md section 3, plus the three known verification issues in section 4.1. Surface what the backend already computed: - 3.1 render surplus_advice in PlanResults, mirroring the shortfall remedies - 3.2 surface VacationBalance.is_assumed so assumed statutory years are visible - 3.3 age-4 expiry given the proposed plan, via a new Age4Projection reusing the existing _age4_projections arithmetic (Dashboard stat verified, not rebuilt) Calendar cluster (one pass over the holiday data): - new GET /api/calendar/days exposing roda dagar, klamdagar and day overrides, paginated four years at a time - 3.4 shade roda dagar/klamdagar, with R/K badges so colour is not the only signal - 3.6 click-to-override behind an explicit mode toggle, leaving drag multi-select intact - 3.7 click month/year to advance - 3.8 per-year red-days list in Settings, statutory days plus overrides i18n: - 3.5 five backend-generated Swedish surfaces converted to message_key + data, following the tips_service pattern; old string fields replaced, not kept Flexible wishes (3.9): - PLANNING_ENGINE_SPEC section 10: window_mode, candidate search, cost function, deterministic tie-break, two-pass ordering, test matrix rows 15-24 - backend: entity, migration 006, _FULL_SCHEMA sync, repository, allocator - frontend: season-preset toggle in WishEditor, unplaced outcome rendering Fixes (4.1): - pin typecheck to the local tsc rather than npx resolving a newer TypeScript - ignore generated coverage/ and dist/ in the ESLint flat config - fix the flaky usePlanApply test properly, with waitFor rather than a retry Tests: backend 361 -> 404, frontend 540 -> 704. Coverage 89.47% -> 96.52% lines. Not yet verified in a browser. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RXMhc9nT6sNz1SL4j8dznL
2026-09-14 02:33:03 +02:00
parent 3ca1418d94
commit 76b1e712b9
218 changed files with 29867 additions and 6085 deletions
@@ -0,0 +1,273 @@
+import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest'
+import { renderHook, waitFor, act } from '@testing-library/react'
+import type { ReactNode } from 'react'
+import { WorkspaceProvider, useWorkspace } from './WorkspaceContext'
+import * as api from '@/services/api'
+import { useAuth } from '@/context/AuthContext'
+import type { Workspace } from '@/types'
+
+vi.mock('@/services/api')
+vi.mock('@/context/AuthContext', () => ({
+  useAuth: vi.fn(),
+}))
+
+function wrapper({ children }: { children: ReactNode }) {
+  return <WorkspaceProvider>{children}</WorkspaceProvider>
+}
+
+// Node's own experimental `localStorage` global (active in newer Node runtimes
+// without a valid --localstorage-file) shadows jsdom's working implementation
+// and throws on every call. Stub a real in-memory Storage for these tests.
+function createLocalStorageMock(): Storage {
+  let store: Record<string, string> = {}
+  return {
+    getItem: (key: string) => (key in store ? store[key]! : null),
+    setItem: (key: string, value: string) => {
+      store[key] = value
+    },
+    removeItem: (key: string) => {
+      delete store[key]
+    },
+    clear: () => {
+      store = {}
+    },
+    key: (index: number) => Object.keys(store)[index] ?? null,
+    get length() {
+      return Object.keys(store).length
+    },
+  }
+}
+
+const authenticated = {
+  accessToken: 'tok',
+  isAuthenticated: true,
+  isLoading: false,
+  login: vi.fn(),
+  register: vi.fn(),
+  logout: vi.fn(),
+}
+
+const unauthenticated = {
+  accessToken: null,
+  isAuthenticated: false,
+  isLoading: false,
+  login: vi.fn(),
+  register: vi.fn(),
+  logout: vi.fn(),
+}
+
+const workspace: Workspace = {
+  id: 'ws1',
+  name: 'Our workspace',
+  planningGoal: 'balanced',
+  planningMode: 'couple',
+  createdAt: '2026-01-01T00:00:00Z',
+}
+
+const userContext: api.UserContext = {
+  personal_data_uuid: 'pd1',
+  workspace_id: 'ws1',
+  parent_name: 'Anna',
+  children: [
+    { id: 'c1', name: 'Child One', birth_date: '2024-01-01' },
+    { id: 'c2', name: 'Child Two', birth_date: '2025-01-01' },
+  ],
+}
+
+describe('WorkspaceContext', () => {
+  beforeEach(() => {
+    vi.clearAllMocks()
+    vi.stubGlobal('localStorage', createLocalStorageMock())
+  })
+
+  afterEach(() => {
+    vi.unstubAllGlobals()
+  })
+
+  it('does nothing when the user is not authenticated', async () => {
+    vi.mocked(useAuth).mockReturnValue(unauthenticated)
+
+    const { result } = renderHook(() => useWorkspace(), { wrapper })
+
+    expect(api.getUserContext).not.toHaveBeenCalled()
+    expect(result.current.workspace).toBeNull()
+    expect(result.current.isLoading).toBe(false)
+  })
+
+  it('loads user context and workspace on mount when authenticated', async () => {
+    vi.mocked(useAuth).mockReturnValue(authenticated)
+    vi.mocked(api.getUserContext).mockResolvedValue(userContext)
+    vi.mocked(api.getWorkspace).mockResolvedValue(workspace)
+
+    const { result } = renderHook(() => useWorkspace(), { wrapper })
+
+    await waitFor(() => expect(result.current.workspace).not.toBeNull())
+
+    expect(api.getUserContext).toHaveBeenCalled()
+    expect(api.getWorkspace).toHaveBeenCalledWith('ws1')
+    expect(result.current.workspaceId).toBe('ws1')
+    expect(result.current.personalDataUuid).toBe('pd1')
+    expect(result.current.parentName).toBe('Anna')
+    expect(result.current.children).toHaveLength(2)
+    expect(result.current.selectedChildId).toBe('c1')
+    expect(result.current.workspace).toEqual(workspace)
+    expect(localStorage.getItem('workspaceId')).toBe('ws1')
+    expect(result.current.isLoading).toBe(false)
+  })
+
+  it('sets an error when loading the user context fails', async () => {
+    vi.mocked(useAuth).mockReturnValue(authenticated)
+    vi.mocked(api.getUserContext).mockRejectedValue(new Error('context boom'))
+
+    const { result } = renderHook(() => useWorkspace(), { wrapper })
+
+    await waitFor(() => expect(result.current.isLoading).toBe(false))
+
+    expect(result.current.error).toBe('context boom')
+    expect(result.current.workspace).toBeNull()
+  })
+
+  it('sets a non-Error rejection to a generic message when loading the user context fails', async () => {
+    vi.mocked(useAuth).mockReturnValue(authenticated)
+    vi.mocked(api.getUserContext).mockRejectedValue('nope')
+
+    const { result } = renderHook(() => useWorkspace(), { wrapper })
+
+    await waitFor(() => expect(result.current.isLoading).toBe(false))
+
+    expect(result.current.error).toBe('Failed to load user context')
+  })
+
+  it('sets an error when the workspace fetch inside refreshContext fails', async () => {
+    vi.mocked(useAuth).mockReturnValue(authenticated)
+    vi.mocked(api.getUserContext).mockResolvedValue(userContext)
+    vi.mocked(api.getWorkspace).mockRejectedValue(new Error('workspace boom'))
+
+    const { result } = renderHook(() => useWorkspace(), { wrapper })
+
+    await waitFor(() => expect(result.current.isLoading).toBe(false))
+
+    expect(result.current.error).toBe('workspace boom')
+    expect(result.current.workspace).toBeNull()
+    // But the rest of the context from getUserContext was still applied.
+    expect(result.current.workspaceId).toBe('ws1')
+    expect(result.current.selectedChildId).toBe('c1')
+  })
+
+  it('defaults to an empty children list when the context response omits children', async () => {
+    vi.mocked(useAuth).mockReturnValue(authenticated)
+    const contextWithoutChildren = {
+      personal_data_uuid: userContext.personal_data_uuid,
+      workspace_id: userContext.workspace_id,
+      parent_name: userContext.parent_name,
+    } as unknown as api.UserContext
+    vi.mocked(api.getUserContext).mockResolvedValue(contextWithoutChildren)
+    vi.mocked(api.getWorkspace).mockResolvedValue(workspace)
+
+    const { result } = renderHook(() => useWorkspace(), { wrapper })
+
+    await waitFor(() => expect(result.current.workspace).not.toBeNull())
+
+    expect(result.current.children).toEqual([])
+    expect(result.current.selectedChildId).toBeNull()
+  })
+
+  it('sets a non-Error rejection to a generic message when the workspace fetch inside refreshContext fails', async () => {
+    vi.mocked(useAuth).mockReturnValue(authenticated)
+    vi.mocked(api.getUserContext).mockResolvedValue(userContext)
+    vi.mocked(api.getWorkspace).mockRejectedValue('nope')
+
+    const { result } = renderHook(() => useWorkspace(), { wrapper })
+
+    await waitFor(() => expect(result.current.isLoading).toBe(false))
+
+    expect(result.current.error).toBe('Failed to load workspace')
+    expect(result.current.workspace).toBeNull()
+  })
+
+  it('refetch sets a non-Error rejection to a generic message', async () => {
+    vi.mocked(useAuth).mockReturnValue(authenticated)
+    vi.mocked(api.getUserContext).mockResolvedValue(userContext)
+    vi.mocked(api.getWorkspace).mockResolvedValue(workspace)
+
+    const { result } = renderHook(() => useWorkspace(), { wrapper })
+    await waitFor(() => expect(result.current.workspace).not.toBeNull())
+
+    vi.mocked(api.getWorkspace).mockRejectedValue('nope')
+
+    act(() => {
+      result.current.refetch()
+    })
+
+    await waitFor(() => expect(result.current.error).toBe('Failed to load workspace'))
+    expect(result.current.workspace).toBeNull()
+  })
+
+  it('selectChild updates the selected child id', async () => {
+    vi.mocked(useAuth).mockReturnValue(authenticated)
+    vi.mocked(api.getUserContext).mockResolvedValue(userContext)
+    vi.mocked(api.getWorkspace).mockResolvedValue(workspace)
+
+    const { result } = renderHook(() => useWorkspace(), { wrapper })
+    await waitFor(() => expect(result.current.selectedChildId).toBe('c1'))
+
+    act(() => {
+      result.current.selectChild('c2')
+    })
+
+    expect(result.current.selectedChildId).toBe('c2')
+  })
+
+  it('setWorkspaceId stores the id and updates state', async () => {
+    vi.mocked(useAuth).mockReturnValue(authenticated)
+    vi.mocked(api.getUserContext).mockResolvedValue(userContext)
+    vi.mocked(api.getWorkspace).mockResolvedValue(workspace)
+
+    const { result } = renderHook(() => useWorkspace(), { wrapper })
+    await waitFor(() => expect(result.current.workspace).not.toBeNull())
+
+    act(() => {
+      result.current.setWorkspaceId('ws2')
+    })
+
+    expect(result.current.workspaceId).toBe('ws2')
+    expect(localStorage.getItem('workspaceId')).toBe('ws2')
+  })
+
+  it('refetch re-fetches the current workspace', async () => {
+    vi.mocked(useAuth).mockReturnValue(authenticated)
+    vi.mocked(api.getUserContext).mockResolvedValue(userContext)
+    vi.mocked(api.getWorkspace).mockResolvedValue(workspace)
+
+    const { result } = renderHook(() => useWorkspace(), { wrapper })
+    await waitFor(() => expect(result.current.workspace).not.toBeNull())
+
+    vi.mocked(api.getWorkspace).mockClear()
+
+    act(() => {
+      result.current.refetch()
+    })
+
+    await waitFor(() => expect(api.getWorkspace).toHaveBeenCalledWith('ws1'))
+  })
+
+  it('refetch is a no-op without a workspaceId', () => {
+    vi.mocked(useAuth).mockReturnValue(unauthenticated)
+
+    const { result } = renderHook(() => useWorkspace(), { wrapper })
+
+    act(() => {
+      result.current.refetch()
+    })
+
+    expect(api.getWorkspace).not.toHaveBeenCalled()
+  })
+
+  it('throws when useWorkspace is used outside a WorkspaceProvider', () => {
+    vi.mocked(useAuth).mockReturnValue(unauthenticated)
+
+    expect(() => renderHook(() => useWorkspace())).toThrow(
+      'useWorkspace must be used inside <WorkspaceProvider>',
+    )
+  })
+})