Files
F-r-ldraledigplannerare/frontend/src/context/AuthContext.test.tsx
T
jacobh2 02db5430eb Harden the API and the data layer after a security and performance audit
Security
- Every route now requires a login and refuses ids outside the caller's
  workspace with 404: plan, leave-wishes, day-overrides and vacation-days
  were fully anonymous; every other router trusted client-supplied
  workspace/child/parent ids. Scraper sessions are bound to their owner.
- Invitations can no longer be created for a foreign workspace, and a
  redeemer who is already a member (or a full workspace) is refused.
- Production refuses the default JWT secret; API docs are hidden in
  production; a failed migration aborts startup instead of serving.
- Login and register no longer reveal whether an email exists; inactive
  accounts are rejected; /auth/refresh is rate limited.
- The FK scraper writes debug artefacts only when explicitly enabled,
  logs no scraped values or page text, clears the BankID QR as soon as it
  is scanned and purges finished sessions after five minutes.
- Real FK page captures are removed from the tree (history rewrite
  follows); the parser tests use a synthetic fixture.

Performance and correctness
- Plan apply/sync run inside one locked transaction with batched writes
  instead of one commit per row, so a failure mid-batch leaves nothing
  half-applied and concurrent syncs no longer corrupt each other.
- SQLite runs in WAL mode with a busy timeout; 14 indexes cover the
  filters that were full scans; argon2 hashing runs off the event loop;
  responses are gzipped.
- Frontend: a 401 now refreshes the token once and retries, so sessions
  no longer die silently after 15 minutes; every data hook discards
  stale responses; logout clears state even when the server call fails.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CsXCCcDfmV4Sps4ZQSvNEY
2026-09-18 07:54:21 +02:00

172 lines
6.0 KiB
TypeScript

import { describe, it, expect, beforeEach, vi } from 'vitest'
import { renderHook, waitFor, act } from '@testing-library/react'
import type { ReactNode } from 'react'
import { AuthProvider, useAuth } from './AuthContext'
import * as api from '@/services/api'
import { ApiRequestError } from '@/services/errors'
import type { TokenResponse } from '@/types'
vi.mock('@/services/api')
function wrapper({ children }: { children: ReactNode }) {
return <AuthProvider>{children}</AuthProvider>
}
const tokenResponse: TokenResponse = {
access_token: 'token-abc',
token_type: 'bearer',
expires_in: 3600,
}
describe('AuthContext', () => {
beforeEach(() => {
vi.clearAllMocks()
// Default mount behavior: no valid refresh cookie, so the effect settles
// to a logged-out state unless a test overrides this.
vi.mocked(api.refreshToken).mockRejectedValue(
new ApiRequestError(401, { code: '401', message: 'Unauthorized' }),
)
})
it('refreshes the access token successfully on mount', async () => {
vi.mocked(api.refreshToken).mockResolvedValue(tokenResponse)
const { result } = renderHook(() => useAuth(), { wrapper })
expect(result.current.isLoading).toBe(true)
await waitFor(() => expect(result.current.isLoading).toBe(false))
expect(result.current.isAuthenticated).toBe(true)
expect(result.current.accessToken).toBe('token-abc')
expect(api.setAccessToken).toHaveBeenCalledWith('token-abc')
})
it('logs the user out when the mount refresh fails with 401', async () => {
vi.mocked(api.refreshToken).mockRejectedValue(
new ApiRequestError(401, { code: '401', message: 'Unauthorized' }),
)
const { result } = renderHook(() => useAuth(), { wrapper })
await waitFor(() => expect(result.current.isLoading).toBe(false))
expect(result.current.isAuthenticated).toBe(false)
expect(result.current.accessToken).toBeNull()
})
it('also lands in a logged-out state when the mount refresh fails with a non-401 error', async () => {
vi.mocked(api.refreshToken).mockRejectedValue(new Error('network down'))
const { result } = renderHook(() => useAuth(), { wrapper })
await waitFor(() => expect(result.current.isLoading).toBe(false))
expect(result.current.isAuthenticated).toBe(false)
expect(result.current.accessToken).toBeNull()
})
it('login updates state and stores the access token', async () => {
vi.mocked(api.login).mockResolvedValue(tokenResponse)
const { result } = renderHook(() => useAuth(), { wrapper })
await waitFor(() => expect(result.current.isLoading).toBe(false))
await act(async () => {
await result.current.login({ email: 'a@b.com', password: 'secret' })
})
expect(api.login).toHaveBeenCalledWith({ email: 'a@b.com', password: 'secret' })
expect(api.setAccessToken).toHaveBeenCalledWith('token-abc')
expect(result.current.isAuthenticated).toBe(true)
expect(result.current.accessToken).toBe('token-abc')
})
it('register updates state and stores the access token', async () => {
vi.mocked(api.register).mockResolvedValue(tokenResponse)
const { result } = renderHook(() => useAuth(), { wrapper })
await waitFor(() => expect(result.current.isLoading).toBe(false))
await act(async () => {
await result.current.register({
email: 'a@b.com',
password: 'secret',
displayName: 'Anna',
})
})
expect(api.register).toHaveBeenCalledWith({
email: 'a@b.com',
password: 'secret',
displayName: 'Anna',
})
expect(result.current.isAuthenticated).toBe(true)
expect(result.current.accessToken).toBe('token-abc')
})
it('logout clears state and the stored access token', async () => {
vi.mocked(api.refreshToken).mockResolvedValue(tokenResponse)
vi.mocked(api.logout).mockResolvedValue(undefined)
const { result } = renderHook(() => useAuth(), { wrapper })
await waitFor(() => expect(result.current.isAuthenticated).toBe(true))
await act(async () => {
await result.current.logout()
})
expect(api.logout).toHaveBeenCalled()
expect(api.setAccessToken).toHaveBeenCalledWith(null)
expect(result.current.isAuthenticated).toBe(false)
expect(result.current.accessToken).toBeNull()
})
it('clears local state even when the server logout call rejects (S3 — offline logout)', async () => {
vi.mocked(api.refreshToken).mockResolvedValue(tokenResponse)
vi.mocked(api.logout).mockRejectedValue(new Error('network down'))
const { result } = renderHook(() => useAuth(), { wrapper })
await waitFor(() => expect(result.current.isAuthenticated).toBe(true))
// The rejection still propagates to the caller (Layout decides how to
// handle a failed best-effort server call) — but local state must
// already be cleared by the time it does.
await act(async () => {
await expect(result.current.logout()).rejects.toThrow('network down')
})
expect(api.setAccessToken).toHaveBeenCalledWith(null)
expect(result.current.isAuthenticated).toBe(false)
expect(result.current.accessToken).toBeNull()
})
it('logs the user out when apiFetch reports a failed refresh-and-retry (S1 interceptor wiring)', async () => {
vi.mocked(api.refreshToken).mockResolvedValue(tokenResponse)
const { result } = renderHook(() => useAuth(), { wrapper })
await waitFor(() => expect(result.current.isAuthenticated).toBe(true))
// Simulate services/api.ts's apiFetch invoking the handler AuthContext
// registered via api.setUnauthorizedHandler after a mid-session 401's
// refresh-and-retry gives up.
const registeredHandler = vi.mocked(api.setUnauthorizedHandler).mock.calls.find(
(call) => call[0] !== null,
)?.[0]
expect(registeredHandler).toBeInstanceOf(Function)
act(() => {
registeredHandler?.()
})
expect(result.current.isAuthenticated).toBe(false)
expect(result.current.accessToken).toBeNull()
})
it('throws when useAuth is used outside an AuthProvider', () => {
expect(() => renderHook(() => useAuth())).toThrow(
'useAuth must be used inside <AuthProvider>',
)
})
})