jacobh2
97a7200c1a
The scraper never read "överlåtbara dagar" from Försäkringskassan. It only visited ansok-och-planera-foraldrapenning#/valjdagar and derived the reserved/transferable split in build_snapshot, assuming transferable days are spent before reserved ones. On real data that gave 49 for the user and 0 for the partner where FK states 129 and 71. The assumption cannot be repaired: reserved-first, transferable-first, proportional and cap-based models were all checked against real figures and none reproduces FK's accounting (reserved-first fits the partner but is 10 days off for the user). FK publishes the real numbers per parent per tier on the min-foraldrapenning page, which the scraper had never visited. - Scrape the "Dagar ni kan föra över" panel after the valjdagar extraction, summing sjukpenningnivå + lägstanivå per parent. The totals are not literals on the page. Parse only direct-child <p> elements: the first group embeds a tooltip with decoy "45 dagar"/"90 dagar" text. - build_snapshot accepts the reported value and derives reserved days from it; the old arithmetic remains only as a fallback. An implausible FK value degrades to that fallback rather than failing the fetch. - Record provenance in transferable_days_reported (migration 006) and badge derived values as estimates in the dashboard breakdown. Drop the footnote's claim that at most 150 days are transferable — real data contradicts it as a per-family figure. - Select the child's section by name when FK lists several; never guess. Verified against a live BankID scrape: scraped 240/101/139 with 129 transferable, deduced partner 240/169/71 with 71, both flagged as reported. Incidental fixes found along the way: - The fetch router never forwarded the partner's transferable figure to persist_partner_deduction, so the partner's stored snapshot would have kept the flawed split even once the parse landed. - 'deduced' snapshots were labelled "Manually entered" by a two-way ternary over a three-value union. Replaced with a compiler-checked exhaustive map. - Alembic resolved its database from alembic.ini alone, ignoring APP_SQLITE_PATH, so migrations silently targeted the developer's real database even when pointed elsewhere. env.py now resolves it, preferring -x sqlalchemy.url, then a real APP_SQLITE_PATH, then the ini value. - backend/captures/ was not ignored: the root pattern was anchored as /captures/ despite a comment saying scraper dumps must never be tracked. - CLAUDE.md quoted test counts and coverage percentages that had gone stale, which made a correct verification report look suspect. Gate thresholds kept. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DXPBfr1v7F71t6QcbHCaaT
45 lines
1.5 KiB
Python
45 lines
1.5 KiB
Python
"""Add parental_leave_fetch.transferable_days_reported.
|
|
|
|
Tracks provenance of `transferable_days_left`: True when it is FK's own
|
|
reported figure (parsed from the "Dagar ni kan föra över" panel on the
|
|
`min-foraldrapenning` e-service page, or a detailed manual entry that
|
|
supplied it directly); False when `app.services.leave_snapshot.build_snapshot`
|
|
derived it via the transferable-first fallback (manual entry with no split
|
|
known, or a failed parse of that panel).
|
|
|
|
Existing rows default to false, which is accurate — every snapshot persisted
|
|
before this migration was derived via the fallback, never FK-reported.
|
|
|
|
A plain `ADD COLUMN` suffices here (like 003's `take_pl_on_red_days`, unlike
|
|
002's CHECK-constraint change which needed a full table rebuild) since
|
|
SQLite supports adding a NOT NULL column with a constant DEFAULT directly.
|
|
|
|
Must stay byte-for-byte equivalent to the `parental_leave_fetch` table in
|
|
`app/db/connection.py`'s `_FULL_SCHEMA` —
|
|
`tests/integration/test_schema_parity.py` asserts exactly that.
|
|
|
|
Revision ID: 006
|
|
Revises: 005
|
|
Create Date: 2026-09-20
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from alembic import op
|
|
|
|
revision: str = "006"
|
|
down_revision: str | None = "005"
|
|
branch_labels: str | None = None
|
|
depends_on: str | None = None
|
|
|
|
|
|
def upgrade() -> None:
|
|
op.execute(
|
|
"ALTER TABLE parental_leave_fetch "
|
|
"ADD COLUMN transferable_days_reported INTEGER NOT NULL DEFAULT 0"
|
|
)
|
|
|
|
|
|
def downgrade() -> None:
|
|
op.execute("ALTER TABLE parental_leave_fetch DROP COLUMN transferable_days_reported")
|