jacobh2
76b1e712b9
Works through every numbered item in NextSteps260913.md section 3, plus the three known verification issues in section 4.1. Surface what the backend already computed: - 3.1 render surplus_advice in PlanResults, mirroring the shortfall remedies - 3.2 surface VacationBalance.is_assumed so assumed statutory years are visible - 3.3 age-4 expiry given the proposed plan, via a new Age4Projection reusing the existing _age4_projections arithmetic (Dashboard stat verified, not rebuilt) Calendar cluster (one pass over the holiday data): - new GET /api/calendar/days exposing roda dagar, klamdagar and day overrides, paginated four years at a time - 3.4 shade roda dagar/klamdagar, with R/K badges so colour is not the only signal - 3.6 click-to-override behind an explicit mode toggle, leaving drag multi-select intact - 3.7 click month/year to advance - 3.8 per-year red-days list in Settings, statutory days plus overrides i18n: - 3.5 five backend-generated Swedish surfaces converted to message_key + data, following the tips_service pattern; old string fields replaced, not kept Flexible wishes (3.9): - PLANNING_ENGINE_SPEC section 10: window_mode, candidate search, cost function, deterministic tie-break, two-pass ordering, test matrix rows 15-24 - backend: entity, migration 006, _FULL_SCHEMA sync, repository, allocator - frontend: season-preset toggle in WishEditor, unplaced outcome rendering Fixes (4.1): - pin typecheck to the local tsc rather than npx resolving a newer TypeScript - ignore generated coverage/ and dist/ in the ESLint flat config - fix the flaky usePlanApply test properly, with waitFor rather than a retry Tests: backend 361 -> 404, frontend 540 -> 704. Coverage 89.47% -> 96.52% lines. Not yet verified in a browser. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RXMhc9nT6sNz1SL4j8dznL
73 lines
2.8 KiB
Python
73 lines
2.8 KiB
Python
"""Tests for the Workspace service.
|
|
|
|
Covers workspace creation/update, with a focus on the `planning_mode` field
|
|
(explicit solo/couple planning intent — not inferred from member count).
|
|
"""
|
|
|
|
from uuid import uuid4
|
|
|
|
import pytest
|
|
|
|
from app.services.workspace_service import WorkspaceService
|
|
from app.utils.errors import NotFoundError, ValidationError
|
|
|
|
|
|
class TestWorkspacePlanningMode:
|
|
"""Test planning_mode defaults and validation."""
|
|
|
|
async def test_create_workspace_defaults_to_solo(
|
|
self,
|
|
workspace_service: WorkspaceService,
|
|
) -> None:
|
|
"""A newly created workspace defaults to solo planning mode."""
|
|
ws = await workspace_service.create_workspace("Test WS")
|
|
assert ws.planning_mode == "solo"
|
|
|
|
async def test_update_planning_mode_to_couple(
|
|
self,
|
|
workspace_service: WorkspaceService,
|
|
) -> None:
|
|
"""Updating planning_mode to a valid value ('couple') succeeds."""
|
|
ws = await workspace_service.create_workspace("Test WS")
|
|
updated = await workspace_service.update_workspace(ws.id, planning_mode="couple")
|
|
assert updated.planning_mode == "couple"
|
|
|
|
async def test_update_planning_mode_back_to_solo(
|
|
self,
|
|
workspace_service: WorkspaceService,
|
|
) -> None:
|
|
"""Updating planning_mode back to 'solo' succeeds."""
|
|
ws = await workspace_service.create_workspace("Test WS")
|
|
await workspace_service.update_workspace(ws.id, planning_mode="couple")
|
|
updated = await workspace_service.update_workspace(ws.id, planning_mode="solo")
|
|
assert updated.planning_mode == "solo"
|
|
|
|
async def test_update_planning_mode_invalid_raises(
|
|
self,
|
|
workspace_service: WorkspaceService,
|
|
) -> None:
|
|
"""An invalid planning_mode value raises ValidationError."""
|
|
ws = await workspace_service.create_workspace("Test WS")
|
|
with pytest.raises(ValidationError, match="planning_mode must be one of"):
|
|
await workspace_service.update_workspace(ws.id, planning_mode="throuple")
|
|
|
|
async def test_update_planning_mode_missing_workspace_raises(
|
|
self,
|
|
workspace_service: WorkspaceService,
|
|
) -> None:
|
|
"""Updating planning_mode on a missing workspace raises NotFoundError."""
|
|
with pytest.raises(NotFoundError):
|
|
await workspace_service.update_workspace(uuid4(), planning_mode="couple")
|
|
|
|
async def test_update_name_and_planning_mode_together(
|
|
self,
|
|
workspace_service: WorkspaceService,
|
|
) -> None:
|
|
"""Multiple fields can be updated in the same call."""
|
|
ws = await workspace_service.create_workspace("Old Name")
|
|
updated = await workspace_service.update_workspace(
|
|
ws.id, name="New Name", planning_mode="couple"
|
|
)
|
|
assert updated.name == "New Name"
|
|
assert updated.planning_mode == "couple"
|