Files
F-r-ldraledigplannerare/backend/app/routers/workspace.py
T
jacobh2 02db5430eb Harden the API and the data layer after a security and performance audit
Security
- Every route now requires a login and refuses ids outside the caller's
  workspace with 404: plan, leave-wishes, day-overrides and vacation-days
  were fully anonymous; every other router trusted client-supplied
  workspace/child/parent ids. Scraper sessions are bound to their owner.
- Invitations can no longer be created for a foreign workspace, and a
  redeemer who is already a member (or a full workspace) is refused.
- Production refuses the default JWT secret; API docs are hidden in
  production; a failed migration aborts startup instead of serving.
- Login and register no longer reveal whether an email exists; inactive
  accounts are rejected; /auth/refresh is rate limited.
- The FK scraper writes debug artefacts only when explicitly enabled,
  logs no scraped values or page text, clears the BankID QR as soon as it
  is scanned and purges finished sessions after five minutes.
- Real FK page captures are removed from the tree (history rewrite
  follows); the parser tests use a synthetic fixture.

Performance and correctness
- Plan apply/sync run inside one locked transaction with batched writes
  instead of one commit per row, so a failure mid-batch leaves nothing
  half-applied and concurrent syncs no longer corrupt each other.
- SQLite runs in WAL mode with a busy timeout; 14 indexes cover the
  filters that were full scans; argon2 hashing runs off the event loop;
  responses are gzipped.
- Frontend: a 401 now refreshes the token once and retries, so sessions
  no longer die silently after 15 minutes; every data hook discards
  stale responses; logout clears state even when the server call fails.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CsXCCcDfmV4Sps4ZQSvNEY
2026-09-18 07:54:21 +02:00

208 lines
6.5 KiB
Python

"""HTTP routes for workspace, members, and invitations."""
from uuid import UUID
from fastapi import APIRouter, HTTPException, status
from app.dependencies import (
CurrentUserDep,
CurrentWorkspaceIdDep,
WorkspaceIdDep,
WorkspaceServiceDep,
)
from app.entities.personal_data import PersonalData
from app.models.workspace import (
InvitationResponse,
InviteResponse,
PersonalDataCreate,
PersonalDataResponse,
RedeemInviteRequest,
WorkspaceCreate,
WorkspaceResponse,
WorkspaceUpdate,
)
from app.utils.errors import InvitationError, NotFoundError, ValidationError
router = APIRouter(prefix="/api/workspace", tags=["workspace"])
def _to_response(pd: PersonalData) -> PersonalDataResponse:
return PersonalDataResponse(
uuid=pd.uuid,
workspace_id=pd.workspace_id,
name=pd.name,
salary_type=pd.salary_type,
employment_status=pd.employment_status,
created_at=pd.created_at,
)
def _to_http_error(exc: NotFoundError | ValidationError) -> HTTPException:
"""Map a NotFoundError/ValidationError to an HTTPException.
Both carry an optional `message_key` + `data` pair (§3.5); when present it
becomes the structured `detail` so the frontend never has to parse an
English sentence. Falls back to the plain message for the (rare) error
raised without one.
"""
code = (
status.HTTP_404_NOT_FOUND
if isinstance(exc, NotFoundError)
else status.HTTP_422_UNPROCESSABLE_ENTITY
)
if exc.message_key:
return HTTPException(code, detail={"message_key": exc.message_key, "data": exc.data})
return HTTPException(code, detail=str(exc))
@router.post("", response_model=WorkspaceResponse, status_code=status.HTTP_201_CREATED)
async def create_workspace(
payload: WorkspaceCreate,
service: WorkspaceServiceDep,
_current_user: CurrentUserDep,
) -> WorkspaceResponse:
ws = await service.create_workspace(payload.name)
return WorkspaceResponse.from_entity(ws)
@router.get("/{workspace_id}", response_model=WorkspaceResponse)
async def get_workspace(
workspace_id: WorkspaceIdDep,
service: WorkspaceServiceDep,
) -> WorkspaceResponse:
try:
ws = await service.get_workspace(workspace_id)
except NotFoundError as exc:
raise HTTPException(status.HTTP_404_NOT_FOUND, str(exc)) from exc
return WorkspaceResponse.from_entity(ws)
@router.put("/{workspace_id}", response_model=WorkspaceResponse)
async def update_workspace(
workspace_id: WorkspaceIdDep,
payload: WorkspaceUpdate,
service: WorkspaceServiceDep,
) -> WorkspaceResponse:
try:
ws = await service.update_workspace(workspace_id, payload.name, payload.planning_mode)
except (NotFoundError, ValidationError) as exc:
code = (
status.HTTP_404_NOT_FOUND
if isinstance(exc, NotFoundError)
else status.HTTP_422_UNPROCESSABLE_ENTITY
)
raise HTTPException(code, str(exc)) from exc
return WorkspaceResponse.from_entity(ws)
@router.get("/{workspace_id}/members", response_model=list[PersonalDataResponse])
async def list_members(
workspace_id: WorkspaceIdDep,
service: WorkspaceServiceDep,
) -> list[PersonalDataResponse]:
members = await service.list_members(workspace_id)
return [_to_response(m) for m in members]
@router.post(
"/{workspace_id}/parents",
response_model=PersonalDataResponse,
status_code=status.HTTP_201_CREATED,
)
async def add_placeholder_parent(
workspace_id: WorkspaceIdDep,
payload: PersonalDataCreate,
service: WorkspaceServiceDep,
) -> PersonalDataResponse:
try:
pd = await service.add_placeholder_parent(workspace_id, payload.display_name)
except (NotFoundError, ValidationError) as exc:
raise _to_http_error(exc) from exc
return _to_response(pd)
@router.patch(
"/{workspace_id}/parents/{personal_data_uuid}",
response_model=PersonalDataResponse,
)
async def rename_parent(
workspace_id: WorkspaceIdDep,
personal_data_uuid: UUID,
payload: PersonalDataCreate,
service: WorkspaceServiceDep,
) -> PersonalDataResponse:
try:
pd = await service.rename_member(workspace_id, personal_data_uuid, payload.display_name)
except (NotFoundError, ValidationError) as exc:
raise _to_http_error(exc) from exc
return _to_response(pd)
@router.delete(
"/{workspace_id}/parents/{personal_data_uuid}",
status_code=status.HTTP_204_NO_CONTENT,
)
async def remove_parent(
workspace_id: WorkspaceIdDep,
personal_data_uuid: UUID,
service: WorkspaceServiceDep,
current_user: CurrentUserDep,
) -> None:
try:
await service.remove_member(
workspace_id, personal_data_uuid, current_user.personal_data_uuid
)
except (NotFoundError, ValidationError) as exc:
raise _to_http_error(exc) from exc
@router.post(
"/{workspace_id}/invitations",
response_model=InviteResponse,
status_code=status.HTTP_201_CREATED,
)
async def create_invitation(
workspace_id: WorkspaceIdDep,
service: WorkspaceServiceDep,
current_user: CurrentUserDep,
) -> InviteResponse:
try:
raw_token = await service.invite_partner(workspace_id, current_user.id)
except NotFoundError as exc:
raise HTTPException(status.HTTP_404_NOT_FOUND, str(exc)) from exc
return InviteResponse(token=raw_token)
# Invitation redemption is workspace-agnostic (token carries workspace info).
_inv_router = APIRouter(prefix="/api/invitations", tags=["invitations"])
@_inv_router.post("/redeem", response_model=InvitationResponse)
async def redeem_invitation(
payload: RedeemInviteRequest,
service: WorkspaceServiceDep,
current_user: CurrentUserDep,
) -> InvitationResponse:
try:
inv = await service.redeem_invitation(payload.token, current_user.personal_data_uuid)
except (InvitationError, NotFoundError) as exc:
raise HTTPException(status.HTTP_400_BAD_REQUEST, str(exc)) from exc
return InvitationResponse.from_entity(inv)
@_inv_router.delete("/{invitation_id}", status_code=status.HTTP_204_NO_CONTENT)
async def revoke_invitation(
invitation_id: UUID,
service: WorkspaceServiceDep,
workspace_id: CurrentWorkspaceIdDep,
) -> None:
try:
await service.revoke_invitation(invitation_id, workspace_id)
except (NotFoundError, ValidationError) as exc:
code = (
status.HTTP_404_NOT_FOUND
if isinstance(exc, NotFoundError)
else status.HTTP_422_UNPROCESSABLE_ENTITY
)
raise HTTPException(code, str(exc)) from exc