jacobh2
02db5430eb
Security - Every route now requires a login and refuses ids outside the caller's workspace with 404: plan, leave-wishes, day-overrides and vacation-days were fully anonymous; every other router trusted client-supplied workspace/child/parent ids. Scraper sessions are bound to their owner. - Invitations can no longer be created for a foreign workspace, and a redeemer who is already a member (or a full workspace) is refused. - Production refuses the default JWT secret; API docs are hidden in production; a failed migration aborts startup instead of serving. - Login and register no longer reveal whether an email exists; inactive accounts are rejected; /auth/refresh is rate limited. - The FK scraper writes debug artefacts only when explicitly enabled, logs no scraped values or page text, clears the BankID QR as soon as it is scanned and purges finished sessions after five minutes. - Real FK page captures are removed from the tree (history rewrite follows); the parser tests use a synthetic fixture. Performance and correctness - Plan apply/sync run inside one locked transaction with batched writes instead of one commit per row, so a failure mid-batch leaves nothing half-applied and concurrent syncs no longer corrupt each other. - SQLite runs in WAL mode with a busy timeout; 14 indexes cover the filters that were full scans; argon2 hashing runs off the event loop; responses are gzipped. - Frontend: a 401 now refreshes the token once and retries, so sessions no longer die silently after 15 minutes; every data hook discards stale responses; logout clears state even when the server call fails. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CsXCCcDfmV4Sps4ZQSvNEY
58 lines
2.3 KiB
Python
58 lines
2.3 KiB
Python
"""Business logic for PersonalData (parent profile) settings.
|
|
|
|
Routers call services, not repositories directly (see child_service.py, the
|
|
reference service). This currently only covers the settings-update path
|
|
(`salary_type`, `employment_status`, `min_vacation_days_per_year`) — creation
|
|
lives in AuthService/WorkspaceService, which construct PersonalData directly
|
|
as part of registration/invite flows.
|
|
"""
|
|
|
|
from uuid import UUID
|
|
|
|
from app.entities.personal_data import PersonalData
|
|
from app.repositories.personal_data_repository import PersonalDataRepository
|
|
from app.utils.errors import NotFoundError, ValidationError
|
|
|
|
_MIN_VACATION_DAYS_FLOOR = 0
|
|
_MIN_VACATION_DAYS_CEILING = 60 # generous upper bound; real cap is entitlement-dependent
|
|
|
|
|
|
class PersonalDataService:
|
|
def __init__(self, repo: PersonalDataRepository) -> None:
|
|
self._repo = repo
|
|
|
|
async def get(self, personal_data_uuid: UUID, workspace_id: UUID | None = None) -> PersonalData:
|
|
entity = await self._repo.get_by_id(personal_data_uuid)
|
|
if entity is None or (workspace_id is not None and entity.workspace_id != workspace_id):
|
|
raise NotFoundError(f"PersonalData {personal_data_uuid} not found")
|
|
return entity
|
|
|
|
async def update(
|
|
self,
|
|
personal_data_uuid: UUID,
|
|
salary_type: str | None = None,
|
|
employment_status: str | None = None,
|
|
min_vacation_days_per_year: int | None = None,
|
|
workspace_id: UUID | None = None,
|
|
) -> PersonalData:
|
|
"""Partial update. Raises ValidationError/NotFoundError."""
|
|
entity = await self.get(personal_data_uuid, workspace_id)
|
|
|
|
if salary_type is not None:
|
|
entity.salary_type = salary_type
|
|
if employment_status is not None:
|
|
entity.employment_status = employment_status
|
|
if min_vacation_days_per_year is not None:
|
|
_validate_min_vacation_days(min_vacation_days_per_year)
|
|
entity.min_vacation_days_per_year = min_vacation_days_per_year
|
|
|
|
return await self._repo.update(personal_data_uuid, entity)
|
|
|
|
|
|
def _validate_min_vacation_days(value: int) -> None:
|
|
if not _MIN_VACATION_DAYS_FLOOR <= value <= _MIN_VACATION_DAYS_CEILING:
|
|
raise ValidationError(
|
|
f"min_vacation_days_per_year must be between {_MIN_VACATION_DAYS_FLOOR} "
|
|
f"and {_MIN_VACATION_DAYS_CEILING}"
|
|
)
|