jacobh2
76b1e712b9
Works through every numbered item in NextSteps260913.md section 3, plus the three known verification issues in section 4.1. Surface what the backend already computed: - 3.1 render surplus_advice in PlanResults, mirroring the shortfall remedies - 3.2 surface VacationBalance.is_assumed so assumed statutory years are visible - 3.3 age-4 expiry given the proposed plan, via a new Age4Projection reusing the existing _age4_projections arithmetic (Dashboard stat verified, not rebuilt) Calendar cluster (one pass over the holiday data): - new GET /api/calendar/days exposing roda dagar, klamdagar and day overrides, paginated four years at a time - 3.4 shade roda dagar/klamdagar, with R/K badges so colour is not the only signal - 3.6 click-to-override behind an explicit mode toggle, leaving drag multi-select intact - 3.7 click month/year to advance - 3.8 per-year red-days list in Settings, statutory days plus overrides i18n: - 3.5 five backend-generated Swedish surfaces converted to message_key + data, following the tips_service pattern; old string fields replaced, not kept Flexible wishes (3.9): - PLANNING_ENGINE_SPEC section 10: window_mode, candidate search, cost function, deterministic tie-break, two-pass ordering, test matrix rows 15-24 - backend: entity, migration 006, _FULL_SCHEMA sync, repository, allocator - frontend: season-preset toggle in WishEditor, unplaced outcome rendering Fixes (4.1): - pin typecheck to the local tsc rather than npx resolving a newer TypeScript - ignore generated coverage/ and dist/ in the ESLint flat config - fix the flaky usePlanApply test properly, with waitFor rather than a retry Tests: backend 361 -> 404, frontend 540 -> 704. Coverage 89.47% -> 96.52% lines. Not yet verified in a browser. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RXMhc9nT6sNz1SL4j8dznL
63 lines
1.9 KiB
Python
63 lines
1.9 KiB
Python
"""Domain error types.
|
|
|
|
Use these instead of bare exceptions so services/routers can map them to
|
|
meaningful HTTP responses. Never swallow errors silently (see ARCHITECTURE.md §10).
|
|
"""
|
|
|
|
|
|
class DomainError(Exception):
|
|
"""Base class for all application-domain errors."""
|
|
|
|
|
|
class NotFoundError(DomainError):
|
|
"""Raised when an entity cannot be found by its identifier."""
|
|
|
|
|
|
class ValidationError(DomainError):
|
|
"""Raised when input fails a business rule (not just schema validation)."""
|
|
|
|
|
|
class InsufficientDaysError(DomainError):
|
|
"""Raised when a parent doesn't have enough remaining days to plan."""
|
|
|
|
|
|
class InvalidDayTypeError(ValidationError):
|
|
"""Raised when a planned-day type is not recognized."""
|
|
|
|
|
|
class DubbeldagError(ValidationError):
|
|
"""Raised when a dubbeldag breaks the 15-month window or the 60-day quota.
|
|
|
|
Carries an optional `message_key` + `data` pair (§3.5) alongside the
|
|
human-readable `message` (kept for anything that only logs/prints the
|
|
exception) so callers that need to surface this to the UI — see
|
|
`PlanningService._validate_dubbeldagar_batch` — can build an i18n-ready
|
|
`Rejection` instead of leaking this English string past the backend.
|
|
"""
|
|
|
|
def __init__(
|
|
self,
|
|
message: str,
|
|
message_key: str = "",
|
|
data: dict[str, object] | None = None,
|
|
) -> None:
|
|
super().__init__(message)
|
|
self.message_key = message_key
|
|
self.data: dict[str, object] = data if data is not None else {}
|
|
|
|
|
|
class AuthError(DomainError):
|
|
"""Raised when credentials are invalid or an auth operation fails."""
|
|
|
|
|
|
class UnauthorizedError(DomainError):
|
|
"""Raised when the caller lacks permission to perform an action."""
|
|
|
|
|
|
class ConflictError(DomainError):
|
|
"""Raised when a resource already exists (e.g. duplicate email on register)."""
|
|
|
|
|
|
class InvitationError(ValidationError):
|
|
"""Raised when an invitation token is invalid, expired, or already redeemed."""
|