Files
F-r-ldraledigplannerare/backend/app/routers/workspace.py
T
jacobh2 8ebfcb9462 Add rename and remove for a workspace's placeholder partner
Settings is gaining a partner display, which hides the add-form once a
partner exists. Without these routes a typo'd partner name would be
permanently unfixable, since no endpoint could change or drop one.

PATCH /workspace/{id}/parents/{uuid} renames; DELETE soft-deletes.
Soft rather than hard delete because PersonalData holds PII and the
repository is a SoftDeleteRepository specifically so erasure stays
auditable.

Removal refuses (422) when the member still has leave wishes, planned
leave, parental-leave rows or vacation days, naming the blockers, so a
removal can never orphan plan data. It also refuses for the caller's own
profile, and for a member who has their own login -- the invite/redeem
flow re-points a real user's personal_data into the inviter's workspace,
so soft-deleting that row would silently break their login.

Errors carry message_key + data rather than prose, per the no-Swedish-on
-the-wire rule; NotFoundError/ValidationError gained the same optional
shape DubbeldagError already had, defaulting empty so existing call
sites are unaffected.

Also fixes seed_demo.py constructing WorkspaceService with a stale
3-arg signature, which would have crashed at runtime -- invisible to
pytest since it is a standalone script.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RXMhc9nT6sNz1SL4j8dznL
2026-09-14 18:54:34 +02:00

210 lines
6.6 KiB
Python

"""HTTP routes for workspace, members, and invitations."""
from uuid import UUID
from fastapi import APIRouter, HTTPException, status
from app.dependencies import CurrentUserDep, WorkspaceServiceDep
from app.entities.personal_data import PersonalData
from app.models.workspace import (
InvitationResponse,
InviteResponse,
PersonalDataCreate,
PersonalDataResponse,
RedeemInviteRequest,
WorkspaceCreate,
WorkspaceResponse,
WorkspaceUpdate,
)
from app.utils.errors import InvitationError, NotFoundError, ValidationError
router = APIRouter(prefix="/api/workspace", tags=["workspace"])
def _to_response(pd: PersonalData) -> PersonalDataResponse:
return PersonalDataResponse(
uuid=pd.uuid,
workspace_id=pd.workspace_id,
name=pd.name,
salary_type=pd.salary_type,
employment_status=pd.employment_status,
created_at=pd.created_at,
)
def _to_http_error(exc: NotFoundError | ValidationError) -> HTTPException:
"""Map a NotFoundError/ValidationError to an HTTPException.
Both carry an optional `message_key` + `data` pair (§3.5); when present it
becomes the structured `detail` so the frontend never has to parse an
English sentence. Falls back to the plain message for the (rare) error
raised without one.
"""
code = (
status.HTTP_404_NOT_FOUND
if isinstance(exc, NotFoundError)
else status.HTTP_422_UNPROCESSABLE_ENTITY
)
if exc.message_key:
return HTTPException(code, detail={"message_key": exc.message_key, "data": exc.data})
return HTTPException(code, detail=str(exc))
@router.post("", response_model=WorkspaceResponse, status_code=status.HTTP_201_CREATED)
async def create_workspace(
payload: WorkspaceCreate,
service: WorkspaceServiceDep,
_current_user: CurrentUserDep,
) -> WorkspaceResponse:
ws = await service.create_workspace(payload.name)
return WorkspaceResponse.from_entity(ws)
@router.get("/{workspace_id}", response_model=WorkspaceResponse)
async def get_workspace(
workspace_id: UUID,
service: WorkspaceServiceDep,
_current_user: CurrentUserDep,
) -> WorkspaceResponse:
try:
ws = await service.get_workspace(workspace_id)
except NotFoundError as exc:
raise HTTPException(status.HTTP_404_NOT_FOUND, str(exc)) from exc
return WorkspaceResponse.from_entity(ws)
@router.put("/{workspace_id}", response_model=WorkspaceResponse)
async def update_workspace(
workspace_id: UUID,
payload: WorkspaceUpdate,
service: WorkspaceServiceDep,
_current_user: CurrentUserDep,
) -> WorkspaceResponse:
try:
ws = await service.update_workspace(
workspace_id, payload.name, payload.planning_goal, payload.planning_mode
)
except (NotFoundError, ValidationError) as exc:
code = (
status.HTTP_404_NOT_FOUND
if isinstance(exc, NotFoundError)
else status.HTTP_422_UNPROCESSABLE_ENTITY
)
raise HTTPException(code, str(exc)) from exc
return WorkspaceResponse.from_entity(ws)
@router.get("/{workspace_id}/members", response_model=list[PersonalDataResponse])
async def list_members(
workspace_id: UUID,
service: WorkspaceServiceDep,
_current_user: CurrentUserDep,
) -> list[PersonalDataResponse]:
members = await service.list_members(workspace_id)
return [_to_response(m) for m in members]
@router.post(
"/{workspace_id}/parents",
response_model=PersonalDataResponse,
status_code=status.HTTP_201_CREATED,
)
async def add_placeholder_parent(
workspace_id: UUID,
payload: PersonalDataCreate,
service: WorkspaceServiceDep,
_current_user: CurrentUserDep,
) -> PersonalDataResponse:
try:
pd = await service.add_placeholder_parent(workspace_id, payload.display_name)
except (NotFoundError, ValidationError) as exc:
raise _to_http_error(exc) from exc
return _to_response(pd)
@router.patch(
"/{workspace_id}/parents/{personal_data_uuid}",
response_model=PersonalDataResponse,
)
async def rename_parent(
workspace_id: UUID,
personal_data_uuid: UUID,
payload: PersonalDataCreate,
service: WorkspaceServiceDep,
_current_user: CurrentUserDep,
) -> PersonalDataResponse:
try:
pd = await service.rename_member(workspace_id, personal_data_uuid, payload.display_name)
except (NotFoundError, ValidationError) as exc:
raise _to_http_error(exc) from exc
return _to_response(pd)
@router.delete(
"/{workspace_id}/parents/{personal_data_uuid}",
status_code=status.HTTP_204_NO_CONTENT,
)
async def remove_parent(
workspace_id: UUID,
personal_data_uuid: UUID,
service: WorkspaceServiceDep,
current_user: CurrentUserDep,
) -> None:
try:
await service.remove_member(
workspace_id, personal_data_uuid, current_user.personal_data_uuid
)
except (NotFoundError, ValidationError) as exc:
raise _to_http_error(exc) from exc
@router.post(
"/{workspace_id}/invitations",
response_model=InviteResponse,
status_code=status.HTTP_201_CREATED,
)
async def create_invitation(
workspace_id: UUID,
service: WorkspaceServiceDep,
current_user: CurrentUserDep,
) -> InviteResponse:
try:
raw_token = await service.invite_partner(workspace_id, current_user.id)
except NotFoundError as exc:
raise HTTPException(status.HTTP_404_NOT_FOUND, str(exc)) from exc
return InviteResponse(token=raw_token)
# Invitation redemption is workspace-agnostic (token carries workspace info).
_inv_router = APIRouter(prefix="/api/invitations", tags=["invitations"])
@_inv_router.post("/redeem", response_model=InvitationResponse)
async def redeem_invitation(
payload: RedeemInviteRequest,
service: WorkspaceServiceDep,
current_user: CurrentUserDep,
) -> InvitationResponse:
try:
inv = await service.redeem_invitation(payload.token, current_user.personal_data_uuid)
except (InvitationError, NotFoundError) as exc:
raise HTTPException(status.HTTP_400_BAD_REQUEST, str(exc)) from exc
return InvitationResponse.from_entity(inv)
@_inv_router.delete("/{invitation_id}", status_code=status.HTTP_204_NO_CONTENT)
async def revoke_invitation(
invitation_id: UUID,
service: WorkspaceServiceDep,
_current_user: CurrentUserDep,
) -> None:
try:
await service.revoke_invitation(invitation_id)
except (NotFoundError, ValidationError) as exc:
code = (
status.HTTP_404_NOT_FOUND
if isinstance(exc, NotFoundError)
else status.HTTP_422_UNPROCESSABLE_ENTITY
)
raise HTTPException(code, str(exc)) from exc