jacobh2
4d70c8950d
`uv run pytest` reported 26 DeprecationWarnings, 20 of them raised by code we own. Two independent sources, both already renamed upstream. Starlette renamed HTTP_422_UNPROCESSABLE_ENTITY to HTTP_422_UNPROCESSABLE_CONTENT, matching the RFC 9110 name for the status. Rename all 21 call sites across the twelve routers that raise it. The numeric value is unchanged at 422, so the wire format and the frontend's error handling are untouched -- this is forward-compat debt only. The warnings attributed to fastapi/routing.py were these same handler frames raising through the dependency call, and go with them. Alembic >=1.16 supersedes `version_path_separator` with `path_separator`, which governs both `prepend_sys_path` and `version_locations`; its absence is what triggered the legacy-splitting warning on every config load. Swap the key in alembic.ini. Deliberately not fixing slowapi's `asyncio.iscoroutinefunction` warning (6 of the 26): it is upstream with no released fix, and no `filterwarnings` entry is added, so it stays visible as a reminder to drop the pin once one lands. Verified from backend/: ruff check and format clean, 893 passed with coverage at 92%, and the warnings summary is now exactly those 6 slowapi lines. `alembic upgrade head` runs 001 through 008 without the path_separator warning. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
54 lines
2.1 KiB
Python
54 lines
2.1 KiB
Python
"""HTTP routes for vacation days.
|
|
|
|
Routers stay thin: validate via Pydantic, call the service, map domain errors to
|
|
HTTP. This is the REFERENCE router — copy this shape for other entities.
|
|
"""
|
|
|
|
from uuid import UUID
|
|
|
|
from fastapi import APIRouter, HTTPException, status
|
|
|
|
from app.dependencies import VacationDaysServiceDep, WorkspaceIdDep, WorkspaceScopeDep
|
|
from app.models.vacation_days import VacationDaysCreate, VacationDaysResponse
|
|
from app.utils.errors import NotFoundError, ValidationError
|
|
|
|
router = APIRouter(prefix="/api/vacation-days", tags=["vacation-days"])
|
|
|
|
|
|
@router.post("", response_model=VacationDaysResponse, status_code=status.HTTP_201_CREATED)
|
|
async def upsert_vacation_days(
|
|
payload: VacationDaysCreate, service: VacationDaysServiceDep, scope: WorkspaceScopeDep
|
|
) -> VacationDaysResponse:
|
|
scope.check_workspace(payload.workspace_id)
|
|
await scope.check_member(payload.personal_data_uuid)
|
|
try:
|
|
entity = await service.upsert(
|
|
personal_data_uuid=payload.personal_data_uuid,
|
|
workspace_id=payload.workspace_id,
|
|
year=payload.year,
|
|
total_days=payload.total_days,
|
|
saved_days_in=payload.saved_days_in,
|
|
)
|
|
except ValidationError as exc:
|
|
raise HTTPException(status.HTTP_422_UNPROCESSABLE_CONTENT, str(exc)) from exc
|
|
return VacationDaysResponse.from_entity(entity)
|
|
|
|
|
|
@router.get("/{vacation_days_id}", response_model=VacationDaysResponse)
|
|
async def get_vacation_days(
|
|
vacation_days_id: UUID, service: VacationDaysServiceDep, scope: WorkspaceScopeDep
|
|
) -> VacationDaysResponse:
|
|
try:
|
|
entity = await service.get(vacation_days_id, workspace_id=scope.workspace_id)
|
|
except NotFoundError as exc:
|
|
raise HTTPException(status.HTTP_404_NOT_FOUND, str(exc)) from exc
|
|
return VacationDaysResponse.from_entity(entity)
|
|
|
|
|
|
@router.get("/workspace/{workspace_id}", response_model=list[VacationDaysResponse])
|
|
async def list_vacation_days(
|
|
workspace_id: WorkspaceIdDep, service: VacationDaysServiceDep
|
|
) -> list[VacationDaysResponse]:
|
|
entities = await service.list_for_workspace(workspace_id)
|
|
return [VacationDaysResponse.from_entity(e) for e in entities]
|