jacobh2
76b1e712b9
Works through every numbered item in NextSteps260913.md section 3, plus the three known verification issues in section 4.1. Surface what the backend already computed: - 3.1 render surplus_advice in PlanResults, mirroring the shortfall remedies - 3.2 surface VacationBalance.is_assumed so assumed statutory years are visible - 3.3 age-4 expiry given the proposed plan, via a new Age4Projection reusing the existing _age4_projections arithmetic (Dashboard stat verified, not rebuilt) Calendar cluster (one pass over the holiday data): - new GET /api/calendar/days exposing roda dagar, klamdagar and day overrides, paginated four years at a time - 3.4 shade roda dagar/klamdagar, with R/K badges so colour is not the only signal - 3.6 click-to-override behind an explicit mode toggle, leaving drag multi-select intact - 3.7 click month/year to advance - 3.8 per-year red-days list in Settings, statutory days plus overrides i18n: - 3.5 five backend-generated Swedish surfaces converted to message_key + data, following the tips_service pattern; old string fields replaced, not kept Flexible wishes (3.9): - PLANNING_ENGINE_SPEC section 10: window_mode, candidate search, cost function, deterministic tie-break, two-pass ordering, test matrix rows 15-24 - backend: entity, migration 006, _FULL_SCHEMA sync, repository, allocator - frontend: season-preset toggle in WishEditor, unplaced outcome rendering Fixes (4.1): - pin typecheck to the local tsc rather than npx resolving a newer TypeScript - ignore generated coverage/ and dist/ in the ESLint flat config - fix the flaky usePlanApply test properly, with waitFor rather than a retry Tests: backend 361 -> 404, frontend 540 -> 704. Coverage 89.47% -> 96.52% lines. Not yet verified in a browser. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RXMhc9nT6sNz1SL4j8dznL
89 lines
3.4 KiB
Python
89 lines
3.4 KiB
Python
"""Tests for PersonalDataService — the settings-update path, in particular
|
|
`min_vacation_days_per_year` (Task 1, PLANNING_ENGINE_SPEC §9.2).
|
|
"""
|
|
|
|
from datetime import datetime
|
|
from uuid import uuid4
|
|
|
|
import pytest
|
|
|
|
from app.entities.personal_data import PersonalData
|
|
from app.entities.workspace import Workspace
|
|
from app.repositories_impl.sqlite.personal_data_repository import SQLitePersonalDataRepository
|
|
from app.repositories_impl.sqlite.workspace_repository import SQLiteWorkspaceRepository
|
|
from app.services.personal_data_service import PersonalDataService
|
|
from app.utils.errors import NotFoundError, ValidationError
|
|
|
|
|
|
class TestPersonalDataService:
|
|
async def test_update_min_vacation_days_per_year(
|
|
self,
|
|
personal_data_repo: SQLitePersonalDataRepository,
|
|
workspace_repo: SQLiteWorkspaceRepository,
|
|
) -> None:
|
|
ws = await workspace_repo.create(
|
|
Workspace(id=uuid4(), name="WS", created_at=datetime.now())
|
|
)
|
|
pd = await personal_data_repo.create(
|
|
PersonalData(uuid=uuid4(), workspace_id=ws.id, name="Parent", created_at=datetime.now())
|
|
)
|
|
service = PersonalDataService(personal_data_repo)
|
|
|
|
updated = await service.update(pd.uuid, min_vacation_days_per_year=25)
|
|
|
|
assert updated.min_vacation_days_per_year == 25
|
|
|
|
async def test_update_partial_leaves_other_fields_untouched(
|
|
self,
|
|
personal_data_repo: SQLitePersonalDataRepository,
|
|
workspace_repo: SQLiteWorkspaceRepository,
|
|
) -> None:
|
|
ws = await workspace_repo.create(
|
|
Workspace(id=uuid4(), name="WS", created_at=datetime.now())
|
|
)
|
|
pd = await personal_data_repo.create(
|
|
PersonalData(
|
|
uuid=uuid4(),
|
|
workspace_id=ws.id,
|
|
name="Parent",
|
|
salary_type="hourly",
|
|
min_vacation_days_per_year=22,
|
|
created_at=datetime.now(),
|
|
)
|
|
)
|
|
service = PersonalDataService(personal_data_repo)
|
|
|
|
updated = await service.update(pd.uuid, employment_status="jobseeking")
|
|
|
|
assert updated.salary_type == "hourly"
|
|
assert updated.min_vacation_days_per_year == 22
|
|
assert updated.employment_status == "jobseeking"
|
|
|
|
async def test_update_rejects_out_of_range_minimum(
|
|
self,
|
|
personal_data_repo: SQLitePersonalDataRepository,
|
|
workspace_repo: SQLiteWorkspaceRepository,
|
|
) -> None:
|
|
ws = await workspace_repo.create(
|
|
Workspace(id=uuid4(), name="WS", created_at=datetime.now())
|
|
)
|
|
pd = await personal_data_repo.create(
|
|
PersonalData(uuid=uuid4(), workspace_id=ws.id, name="Parent", created_at=datetime.now())
|
|
)
|
|
service = PersonalDataService(personal_data_repo)
|
|
|
|
with pytest.raises(ValidationError, match="min_vacation_days_per_year"):
|
|
await service.update(pd.uuid, min_vacation_days_per_year=-1)
|
|
|
|
with pytest.raises(ValidationError, match="min_vacation_days_per_year"):
|
|
await service.update(pd.uuid, min_vacation_days_per_year=61)
|
|
|
|
async def test_update_unknown_parent_raises_not_found(
|
|
self,
|
|
personal_data_repo: SQLitePersonalDataRepository,
|
|
) -> None:
|
|
service = PersonalDataService(personal_data_repo)
|
|
|
|
with pytest.raises(NotFoundError):
|
|
await service.update(uuid4(), min_vacation_days_per_year=25)
|