jacobh2
cc3ced905e
Three changes that together unblock treating a calendar period as one editable object. Migration 008 adds `planned_leave_day.wish_id` (nullable, ON DELETE SET NULL) so a persisted day knows which `leave_wish` produced it, `is_pinned` to mark a day the user hand-edited, and `leave_wish.target_days` so a period drawn on a calendar need not be a whole number of weeks. Apply-time identity still keys on day_type/is_dubbeldag only, so a wish_id-only difference is a metadata update rather than a collision. The age-4 savable ceiling was applying the per-child figure of 96 to each parent's pool, modelling a two-parent family as able to save 192 days past the child's fourth birthday. `resolve_age4_savable_cap` is now the single place that decides 48 (couple with two parents) versus 96 (everyone else), and both AnalyticsService and the allocator read it. Migration 009 drops `workspace.planning_goal` and `leave_wish.goal_override`. The allocator's tier-3 policy collapses to one rule; `salary_type` still branches, since that reflects what a vacation day actually costs a parent rather than a user preference.
51 lines
1.5 KiB
Python
51 lines
1.5 KiB
Python
"""Drop workspace.planning_goal and leave_wish.goal_override.
|
|
|
|
Product decision: there is only one sensible allocation objective — maximise
|
|
the value extracted from parental-leave days plus vacation days. Exposing
|
|
`max_time` / `max_money` / `balanced` as a user-facing setting made the
|
|
planner's behaviour unpredictable without making it more useful. The engine
|
|
now always applies what used to be the `max_money` policy; the `goal`
|
|
concept (and the ability to override it per-wish) is removed entirely.
|
|
|
|
Revision ID: 009
|
|
Revises: 008
|
|
Create Date: 2026-09-15
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from alembic import op
|
|
|
|
revision: str = "009"
|
|
down_revision: str | None = "008"
|
|
branch_labels: str | None = None
|
|
depends_on: str | None = None
|
|
|
|
_UPGRADE_SQL = """
|
|
ALTER TABLE workspace DROP COLUMN planning_goal;
|
|
|
|
ALTER TABLE leave_wish DROP COLUMN goal_override;
|
|
"""
|
|
|
|
_DOWNGRADE_SQL = """
|
|
ALTER TABLE workspace ADD COLUMN planning_goal TEXT NOT NULL DEFAULT 'balanced'
|
|
CHECK (planning_goal IN ('max_time','max_money','balanced'));
|
|
|
|
ALTER TABLE leave_wish ADD COLUMN goal_override TEXT
|
|
CHECK (goal_override IS NULL OR goal_override IN ('max_time','max_money','balanced'));
|
|
"""
|
|
|
|
|
|
def upgrade() -> None:
|
|
from sqlalchemy import text
|
|
|
|
for stmt in [s.strip() for s in _UPGRADE_SQL.split(";") if s.strip()]:
|
|
op.execute(text(stmt))
|
|
|
|
|
|
def downgrade() -> None:
|
|
from sqlalchemy import text
|
|
|
|
for stmt in [s.strip() for s in _DOWNGRADE_SQL.split(";") if s.strip()]:
|
|
op.execute(text(stmt))
|