Keep plan warnings in step with the plan they describe
Warnings such as "vacation days at risk of being lost" kept showing after the planner had already resolved them. The planner itself was firing correctly -- PlanSyncProvider syncs on every plan-input change -- so the fault was in the warnings, in two independent places. The vacation-expiry warning was computed before allocation. It read `vacation_forfeiting`, which the loader derives from already-committed usage, while `_assign_tier3` deliberately spends at-risk vacation days first precisely to avoid that forfeiture. The figure therefore counted days the plan was in the middle of saving. `_vacation_expiry_warnings` now subtracts the vacation days this run actually placed for that parent and year, clamped at zero -- sound because the bank is FIFO, so a day spent in year Y retires one expiring day one-for-one. The full carry-forward simulation is still not duplicated inside the ledger. The Dashboard then never refreshed them. Its proposal came from a one-shot effect guarded by `proposal === null`, with no planVersion dependency, so the card kept rendering the pre-replan warning until remount -- while `syncPlan` was already returning a fresh proposal that both call sites discarded. PlanSyncProvider now exposes that proposal behind a monotonic counter, and usePlanProposal prefers it once any sync has completed, keeping `propose()` for the first load. Also adds a manual recompute button to Settings, which only bumps planVersion and reports what the resulting sync did, and fixes partner add/remove never bumping planVersion at all -- that gap meant gaining or losing a parent never re-ran the allocator, though it changes who days can be assigned to. Rename stays cosmetic. Verified in the browser: a 2031 warning of 15 days dropped to 12 after three vacation days were planned, without a reload. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014jPFUcCJ5AKXmPVC1anhXe
This commit is contained in:
Vendored
+13
@@ -12,6 +12,7 @@
|
||||
import { vi } from 'vitest'
|
||||
import type { useWorkspace } from '@/context/WorkspaceContext'
|
||||
import type { useAuth } from '@/context/AuthContext'
|
||||
import type { usePlanSyncContext } from '@/context/PlanSyncProvider'
|
||||
import type { useAnalytics } from '@/hooks/useAnalytics'
|
||||
import type { useParentalLeave } from '@/hooks/useParentalLeave'
|
||||
import type { usePlannedDays } from '@/hooks/usePlannedDays'
|
||||
@@ -63,6 +64,18 @@ export function makeWorkspaceContextValue(
|
||||
}
|
||||
}
|
||||
|
||||
export function makePlanSyncContextValue(
|
||||
overrides: Partial<ReturnType<typeof usePlanSyncContext>> = {},
|
||||
): ReturnType<typeof usePlanSyncContext> {
|
||||
return {
|
||||
pendingEvictionPreview: null,
|
||||
clearPendingEvictionPreview: vi.fn(),
|
||||
latestProposal: null,
|
||||
latestProposalVersion: 0,
|
||||
...overrides,
|
||||
}
|
||||
}
|
||||
|
||||
export function makeAuthContextValue(
|
||||
overrides: Partial<ReturnType<typeof useAuth>> = {},
|
||||
): ReturnType<typeof useAuth> {
|
||||
|
||||
Reference in New Issue
Block a user