jacobh2
014503e89b
The planner knew exactly how many semesterdagar a parent was about to forfeit and never placed a single day to prevent it. It also had no weekend-wrap logic at all: REASON_VACATION_WRAP_WEEKEND was stamped on every tier-3 interior vacation day, including a lone Tuesday in February. Two changes. Spend better. A workday adjacent to a free stretch, or in the middle of a gap of three or fewer fenced by free days, now takes vacation -- _vacation_bridge_reason, consulted for every parent type. This departs from spec 6.1's "wrapping suppressed for hourly": the FP-preservation argument is salary-type independent, only the pay argument was hourly-moot. In a both-parents window, both now take vacation on such a date rather than one paying with FP. After funding, reallocate_vacation_by_value swaps vacation onto higher-ranked dates 1-for-1 with FP days, so which dates hold vacation improves while how many never drops -- greedy first, re-timed after, never withheld. An invariant test asserts the count can only rise. Name the losses. A new pass proposes concrete dates for vacation that would otherwise expire, current year only, ranked red-day bridge then weekend bridge then interior, later dates first. They ride on PlanProposal.rescue_days, kept off `days` so nothing downstream commits them, and surface on the Dashboard with accept-one, accept-all (one batched /api/plan/apply, not N) and dismiss. Dismissal reuses the tip_dismissal table, keyed on (parent, year) identity rather than the group's dates -- those are recomputed from the whole plan's residual on every propose, so date-hashing made dismissal self-defeating. Dismiss does not bump the plan version; it changes no data and must not trigger a write. Measured on the seeded demo: 12 forfeiting days for one parent now yield 12 proposed dates, all Fridays or Mondays. Total vacation placed is unchanged at 203 days, confirming the reallocation only re-times. Three defects here were found by driving a browser, while 2273 unit tests passed -- all three lived in the seam between layers that unit tests mock away. Adds API-level tests over the real request sequence. Rate limiting is now off in tests (one file consumed the whole registration budget) with the suite's first real 429 assertion. PROPOSE_VS_SYNC_BUG.md documents a pre-existing, unfixed issue found along the way: Dashboard figures swing on the first sync with no user action. Backend 946 tests, frontend 1341, coverage above all gates. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YZaX6xbuMEMXuyKA1fq2Mm
Föräldraledigplannerare
A planner for Swedish parental leave (föräldraledighet) — solo or with a partner — that folds in vacation days and optimizes leave over time so that as few days as possible are lost at the child's 4th birthday, after which only 96 days may be saved (48 per parent, non-poolable, as soon as the child has two or more parents).
Full-stack monorepo: TypeScript/React/Vite frontend, Python/FastAPI backend,
SQLite by default. Postgres is a partial stub, not a usable swap yet — see
backend/README.md.
Quick start
From frontend/:
npm install
npm run dev # runs uvicorn (:8000) and Vite (:5173) together
Open http://localhost:5173 (not 127.0.0.1 — Vite's dev server binds
IPv6 ::1, so only localhost resolves to it).
The backend can also run on its own, from backend/:
uv sync
uv run uvicorn app.main:app --reload --port 8000
Seed a ready-to-explore demo workspace (couple, a partner, a child, vacation history, leave wishes, a deliberate shortfall) through the normal service/repository layers — no raw SQL:
cd backend
uv run python scripts/seed_demo.py --reset
It prints the demo login (fixed credentials, safe to re-run — without
--reset it's a no-op if the demo user already exists).
The Försäkringskassan scraper (BankID login flow via Playwright) is enabled
by default. Exercise the login UI directly with npm run login from
frontend/; Chromium must be installed separately:
uv run playwright install chromium.
The app
Three tabs:
- Översikt — the headline figure for days at risk at the 4th birthday, per-parent bars against each parent's savable cap, a year-by-year timeline, and shortfall/surplus detail below the fold.
- Kalender — where leave is authored. Drag a range to create a period, click a band to edit it, click a day to change which resource funds it (sjukpenning/lägstanivå/vacation). A season-preset rail helps place common periods (summer, Christmas, Easter). Day overrides (marking a specific date as a working day or a free day, overriding the calendar) live in Inställningar, not on the calendar itself.
- Inställningar.
The calendar is the plan. There's no separate propose-then-apply step:
every edit recomputes and persists immediately, reporting what changed with
an undo. A LeaveWish is a recurring intent (e.g. "summer", "Christmas");
the allocator decides which resource — parental days, vacation, unpaid —
funds each day, without retyping days a user has pinned by hand.
First run walks a wizard: add the child, optionally add a partner (planning solo vs. together is derived from whether a partner has been added — there is no separate solo/couple choice), then set balances — fetch from Försäkringskassan via BankID, enter manually, or skip (figures are then marked as estimates).
Layout
backend/app/
entities/ persistence-layer row shapes
models/ Pydantic v2 API schemas
repositories/ abstract repository interfaces
repositories_impl/ sqlite/ (default, complete) and postgres/ (partial — one entity only)
services/ business logic — planning, tips, analytics, auth
scrapers/ Försäkringskassan scraper (Playwright)
routers/ thin FastAPI route handlers
backend/migrations/ Alembic migrations (hand-written, not ORM-generated)
backend/scripts/ seed_demo.py and other dev-only scripts
frontend/src/
pages/ route-level screens (Dashboard, Calendar, Settings, ...)
components/ presentational + composite components (BEM CSS)
hooks/ data-fetching/state (the data layer — no TanStack Query)
services/ api.ts (HTTP client) + errors.ts
context/ Auth + Workspace React context
frontend/e2e/ Playwright end-to-end specs
Routers call services; services call the repository interfaces — never
repositories_impl directly. Components consume hooks; hooks call
services/api.ts — components never call fetch directly.
Tests & gates
Backend (from backend/):
uv run ruff check .
uv run ruff format --check .
uv run pytest --cov=app --cov-report=term-missing --cov-fail-under=80
Frontend (from frontend/):
npm run typecheck
npm run lint # ESLint, zero warnings allowed
npm run coverage # Vitest, thresholds: lines 96% / functions 91% / branches 92% / statements 96%
Both suites pass comfortably above their gates (backend ~84% vs. an 80%
floor; frontend above 96/91/92/96 — see frontend/vitest.config.ts). Gates
are a regression ratchet, not a target; run the commands above for current
numbers rather than trusting a hardcoded count here, which drifts fast.
CI (.github/workflows/ci.yml) runs all of the above, plus a Playwright E2E
suite that reports but does not yet block merges.
Further reading
CLAUDE.md— conventions, stack details, model-tier rules for contributors.ARCHITECTURE.md/PLANNING_ENGINE_SPEC.md— design and rationale. Both predate parts of the current behavior; sections marked SUPERSEDED note what changed and why.backend/README.md— backend-specific setup and the reference vertical slice to copy when adding a new entity.