jacobh2
02db5430eb
Security - Every route now requires a login and refuses ids outside the caller's workspace with 404: plan, leave-wishes, day-overrides and vacation-days were fully anonymous; every other router trusted client-supplied workspace/child/parent ids. Scraper sessions are bound to their owner. - Invitations can no longer be created for a foreign workspace, and a redeemer who is already a member (or a full workspace) is refused. - Production refuses the default JWT secret; API docs are hidden in production; a failed migration aborts startup instead of serving. - Login and register no longer reveal whether an email exists; inactive accounts are rejected; /auth/refresh is rate limited. - The FK scraper writes debug artefacts only when explicitly enabled, logs no scraped values or page text, clears the BankID QR as soon as it is scanned and purges finished sessions after five minutes. - Real FK page captures are removed from the tree (history rewrite follows); the parser tests use a synthetic fixture. Performance and correctness - Plan apply/sync run inside one locked transaction with batched writes instead of one commit per row, so a failure mid-batch leaves nothing half-applied and concurrent syncs no longer corrupt each other. - SQLite runs in WAL mode with a busy timeout; 14 indexes cover the filters that were full scans; argon2 hashing runs off the event loop; responses are gzipped. - Frontend: a 401 now refreshes the token once and retries, so sessions no longer die silently after 15 minutes; every data hook discards stale responses; logout clears state even when the server call fails. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CsXCCcDfmV4Sps4ZQSvNEY
42 lines
1.5 KiB
Python
42 lines
1.5 KiB
Python
"""Tests for Settings' production hardening validator.
|
|
|
|
Never mutates the module-level `settings` singleton — constructs fresh
|
|
`Settings()` instances instead, passing kwargs directly (bypassing env/file
|
|
loading concerns) so these tests are isolated from the process environment.
|
|
"""
|
|
|
|
import pytest
|
|
|
|
from app.config import Settings
|
|
|
|
|
|
class TestProductionJwtSecretValidation:
|
|
def test_development_allows_default_secret(self) -> None:
|
|
settings = Settings(app_env="development")
|
|
assert settings.jwt_secret == "dev-secret-change-in-production-min-32-chars"
|
|
|
|
def test_test_env_allows_default_secret(self) -> None:
|
|
settings = Settings(app_env="test")
|
|
assert settings.app_env == "test"
|
|
|
|
def test_production_rejects_default_secret(self) -> None:
|
|
with pytest.raises(ValueError, match="APP_JWT_SECRET"):
|
|
Settings(app_env="production")
|
|
|
|
def test_production_rejects_short_secret(self) -> None:
|
|
with pytest.raises(ValueError, match="APP_JWT_SECRET"):
|
|
Settings(app_env="production", jwt_secret="short-secret")
|
|
|
|
def test_production_accepts_strong_secret(self) -> None:
|
|
strong_secret = "a" * 32
|
|
settings = Settings(app_env="production", jwt_secret=strong_secret)
|
|
assert settings.jwt_secret == strong_secret
|
|
|
|
def test_default_app_env_is_development(self) -> None:
|
|
settings = Settings()
|
|
assert settings.app_env == "development"
|
|
|
|
def test_default_log_level_is_info(self) -> None:
|
|
settings = Settings()
|
|
assert settings.log_level == "INFO"
|