jacobh2
782415122d
The calendar mixed two kinds of truth in one table. `planned_leave_day` was simultaneously the allocator's output cache, the user's override store (`is_pinned`, plus ad-hoc rows with no `wish_id`), and the resource ledger that analytics and the age-4 maths read. The planner therefore had to ask "am I allowed to touch this row?" on every sync, and got it wrong at the edges. Every user assertion is now one `day_assertion` row — a concrete `day_type` replaces a pinned day, a row with no `wish_id` replaces an ad-hoc day, and `day_type='none'` replaces `planned_day_exclusion`. `planned_leave_day` becomes purely derived with a single writer, and `PlanningService.pinned_keys()` is the single answer to "is this day pinned", used by the allocator's loader, by `sync_plan` and by the read router alike. On top of that, every calendar band is now a real event: an ad-hoc band opens the same full editor as a wish-backed one and saving it promotes it to a `LeaveWish`, so it can be named, repeated yearly, assigned to either or both parents, and handed to the planner. "Planering" is a `moveable` toggle plus a from/to month bound plus a separate lock/unlock action on the days themselves, replacing a three-rung ladder whose "planner decides" rung set a search window equal to the drawn dates and so could never move anything. Bugs found and fixed along the way: - The plan erased its own history. Fixed windows clip to today, so an elapsed auto-placed day fell into `stale_keys` and was deleted on the next sync — and a background sync runs on every workspace load. Past rows are now frozen and counted as spent. - Migration 010's downgrade silently destroyed every pinned day and exclusion (`is_pinned` returned as DEFAULT 0, the exclusion table came back empty, exit 0, no warning). It now reconstructs both from `day_assertion`, and 009 itemises what it cannot recover before dropping the table. - Deleting a period left its assertions behind, locking those dates forever with no UI path to clear them. Wish deletion now clears them by `wish_id`. - `DayAssertionService` and `LeaveWishService` committed multi-statement writes without a transaction; a crash mid-write diverged the tables or half-deleted a series. Both now run in a unit of work. - A sibling year's shortfall was never surfaced: the toast only inspected the edited occurrence's outcome, so a fully unfunded later year rendered as an empty band with no warning. - A flexible window whose bound had entirely elapsed was dropped from the proposal with no outcome at all. It now reports as `unplaced`. - Unlocking a period deleted its days instead of returning them to the planner. - The e2e global setup posted to a route deleted in this change, which would have failed the whole suite before its first test. Gates: backend 938 tests / 91% coverage, frontend 1351 / 97.4 | 92.2 | 94.37 | 97.4. Migrations 009 and 010 audited against a hand-built realistic database: the upgrade reconciles exactly and a constraint violation fails safe, leaving the schema at 008. Not complete. Step 4's toggle, month picker and lock/unlock action are verified by browser walk and unit tests, but the partial-lock readout was not exercised. `ideas.md` §7 adds a full plan for the vacation-forfeiture defect (the planner detects expiring days and then does nothing about them) — not implemented here. Remaining smaller items are listed in the session's restructure notes. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T4wjgbVL4HAC5Rdaw75VbV
Föräldraledigplannerare
A planner for Swedish parental leave (föräldraledighet) — solo or with a partner — that folds in vacation days and optimizes leave over time so that as few days as possible are lost at the child's 4th birthday, after which only 96 days may be saved (48 per parent, non-poolable, as soon as the child has two or more parents).
Full-stack monorepo: TypeScript/React/Vite frontend, Python/FastAPI backend,
SQLite by default. Postgres is a partial stub, not a usable swap yet — see
backend/README.md.
Quick start
From frontend/:
npm install
npm run dev # runs uvicorn (:8000) and Vite (:5173) together
Open http://localhost:5173 (not 127.0.0.1 — Vite's dev server binds
IPv6 ::1, so only localhost resolves to it).
The backend can also run on its own, from backend/:
uv sync
uv run uvicorn app.main:app --reload --port 8000
Seed a ready-to-explore demo workspace (couple, a partner, a child, vacation history, leave wishes, a deliberate shortfall) through the normal service/repository layers — no raw SQL:
cd backend
uv run python scripts/seed_demo.py --reset
It prints the demo login (fixed credentials, safe to re-run — without
--reset it's a no-op if the demo user already exists).
The Försäkringskassan scraper (BankID login flow via Playwright) is enabled
by default. Exercise the login UI directly with npm run login from
frontend/; Chromium must be installed separately:
uv run playwright install chromium.
The app
Three tabs:
- Översikt — the headline figure for days at risk at the 4th birthday, per-parent bars against each parent's savable cap, a year-by-year timeline, and shortfall/surplus detail below the fold.
- Kalender — where leave is authored. Drag a range to create a period, click a band to edit it, click a day to change which resource funds it (sjukpenning/lägstanivå/vacation). A season-preset rail helps place common periods (summer, Christmas, Easter). Day overrides (marking a specific date as a working day or a free day, overriding the calendar) live in Inställningar, not on the calendar itself.
- Inställningar.
The calendar is the plan. There's no separate propose-then-apply step:
every edit recomputes and persists immediately, reporting what changed with
an undo. A LeaveWish is a recurring intent (e.g. "summer", "Christmas");
the allocator decides which resource — parental days, vacation, unpaid —
funds each day, without retyping days a user has pinned by hand.
First run walks a wizard: add the child, optionally add a partner (planning solo vs. together is derived from whether a partner has been added — there is no separate solo/couple choice), then set balances — fetch from Försäkringskassan via BankID, enter manually, or skip (figures are then marked as estimates).
Layout
backend/app/
entities/ persistence-layer row shapes
models/ Pydantic v2 API schemas
repositories/ abstract repository interfaces
repositories_impl/ sqlite/ (default, complete) and postgres/ (partial — one entity only)
services/ business logic — planning, tips, analytics, auth
scrapers/ Försäkringskassan scraper (Playwright)
routers/ thin FastAPI route handlers
backend/migrations/ Alembic migrations (hand-written, not ORM-generated)
backend/scripts/ seed_demo.py and other dev-only scripts
frontend/src/
pages/ route-level screens (Dashboard, Calendar, Settings, ...)
components/ presentational + composite components (BEM CSS)
hooks/ data-fetching/state (the data layer — no TanStack Query)
services/ api.ts (HTTP client) + errors.ts
context/ Auth + Workspace React context
frontend/e2e/ Playwright end-to-end specs
Routers call services; services call the repository interfaces — never
repositories_impl directly. Components consume hooks; hooks call
services/api.ts — components never call fetch directly.
Tests & gates
Backend (from backend/):
uv run ruff check .
uv run ruff format --check .
uv run pytest --cov=app --cov-report=term-missing --cov-fail-under=80
Frontend (from frontend/):
npm run typecheck
npm run lint # ESLint, zero warnings allowed
npm run coverage # Vitest, thresholds: lines 96% / functions 91% / branches 92% / statements 96%
Both suites pass comfortably above their gates (backend ~84% vs. an 80%
floor; frontend above 96/91/92/96 — see frontend/vitest.config.ts). Gates
are a regression ratchet, not a target; run the commands above for current
numbers rather than trusting a hardcoded count here, which drifts fast.
CI (.github/workflows/ci.yml) runs all of the above, plus a Playwright E2E
suite that reports but does not yet block merges.
Further reading
CLAUDE.md— conventions, stack details, model-tier rules for contributors.ARCHITECTURE.md/PLANNING_ENGINE_SPEC.md— design and rationale. Both predate parts of the current behavior; sections marked SUPERSEDED note what changed and why.backend/README.md— backend-specific setup and the reference vertical slice to copy when adding a new entity.