jacobh2
02db5430eb
Security - Every route now requires a login and refuses ids outside the caller's workspace with 404: plan, leave-wishes, day-overrides and vacation-days were fully anonymous; every other router trusted client-supplied workspace/child/parent ids. Scraper sessions are bound to their owner. - Invitations can no longer be created for a foreign workspace, and a redeemer who is already a member (or a full workspace) is refused. - Production refuses the default JWT secret; API docs are hidden in production; a failed migration aborts startup instead of serving. - Login and register no longer reveal whether an email exists; inactive accounts are rejected; /auth/refresh is rate limited. - The FK scraper writes debug artefacts only when explicitly enabled, logs no scraped values or page text, clears the BankID QR as soon as it is scanned and purges finished sessions after five minutes. - Real FK page captures are removed from the tree (history rewrite follows); the parser tests use a synthetic fixture. Performance and correctness - Plan apply/sync run inside one locked transaction with batched writes instead of one commit per row, so a failure mid-batch leaves nothing half-applied and concurrent syncs no longer corrupt each other. - SQLite runs in WAL mode with a busy timeout; 14 indexes cover the filters that were full scans; argon2 hashing runs off the event loop; responses are gzipped. - Frontend: a 401 now refreshes the token once and retries, so sessions no longer die silently after 15 minutes; every data hook discards stale responses; logout clears state even when the server call fails. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CsXCCcDfmV4Sps4ZQSvNEY
62 lines
2.2 KiB
Python
62 lines
2.2 KiB
Python
"""Business logic for vacation days.
|
|
|
|
The service owns rules; the repository only persists. Routers call services, not
|
|
repositories directly. This is the REFERENCE service — keep services thin and
|
|
free of HTTP/DB details.
|
|
"""
|
|
|
|
from datetime import datetime
|
|
from uuid import UUID, uuid4
|
|
|
|
from app.entities.vacation_days import VacationDays
|
|
from app.repositories.vacation_days_repository import VacationDaysRepository
|
|
from app.utils.errors import NotFoundError, ValidationError
|
|
|
|
|
|
class VacationDaysService:
|
|
def __init__(self, repo: VacationDaysRepository) -> None:
|
|
self._repo = repo
|
|
|
|
async def upsert(
|
|
self,
|
|
personal_data_uuid: UUID,
|
|
workspace_id: UUID,
|
|
year: int,
|
|
total_days: int,
|
|
saved_days_in: int = 0,
|
|
) -> VacationDays:
|
|
"""Create or update the (parent, year) vacation entry.
|
|
|
|
Raises ValidationError on negative inputs (schema also guards this, but a
|
|
service should not trust its caller).
|
|
"""
|
|
if total_days < 0 or saved_days_in < 0:
|
|
raise ValidationError("Vacation day counts cannot be negative")
|
|
|
|
existing = await self._repo.get_by_parent_year(personal_data_uuid, year)
|
|
if existing is not None:
|
|
existing.total_days = total_days
|
|
existing.saved_days_in = saved_days_in
|
|
return await self._repo.update(existing.id, existing)
|
|
|
|
entity = VacationDays(
|
|
id=uuid4(),
|
|
personal_data_uuid=personal_data_uuid,
|
|
workspace_id=workspace_id,
|
|
year=year,
|
|
total_days=total_days,
|
|
saved_days_in=saved_days_in,
|
|
created_at=datetime.now(),
|
|
updated_at=datetime.now(),
|
|
)
|
|
return await self._repo.create(entity)
|
|
|
|
async def get(self, vacation_days_id: UUID, workspace_id: UUID | None = None) -> VacationDays:
|
|
entity = await self._repo.get_by_id(vacation_days_id)
|
|
if entity is None or (workspace_id is not None and entity.workspace_id != workspace_id):
|
|
raise NotFoundError(f"VacationDays {vacation_days_id} not found")
|
|
return entity
|
|
|
|
async def list_for_workspace(self, workspace_id: UUID) -> list[VacationDays]:
|
|
return await self._repo.list(workspace_id=workspace_id)
|